Skip to content

core/validatorapi: v1/v2 endpoints warning #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

pinebit
Copy link
Collaborator

@pinebit pinebit commented Dec 19, 2024

Simply added WARN logging when v1/v2 propose endpoints are being hit.

category: feature
ticket: #3405

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.93%. Comparing base (062b69d) to head (0b1e3ad).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3431      +/-   ##
==========================================
+ Coverage   56.88%   56.93%   +0.04%     
==========================================
  Files         218      218              
  Lines       32390    32392       +2     
==========================================
+ Hits        18426    18443      +17     
+ Misses      12071    12057      -14     
+ Partials     1893     1892       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev
Copy link
Collaborator

@pinebit if rebased the pre-commit hook should be fixed

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 8, 2025
Copy link

sonarqubecloud bot commented Jan 8, 2025

@obol-bulldozer obol-bulldozer bot merged commit c0e1851 into main Jan 8, 2025
12 of 13 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/v2-endpoint-warn branch January 8, 2025 12:20
DiogoSantoss pushed a commit that referenced this pull request Jan 14, 2025
Simply added WARN logging when v1/v2 propose endpoints are being hit.

category: feature
ticket: #3405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants